Sebin/task/#2284 upgrade cypress to the latest ricardo #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grade-cypress-to-the-latest
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/cypress@7.7.0) |
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2284-upgrade-cypress-to-the-latest-ricardo
|
| Run status |
|
| Run duration | 09m 42s |
| Commit |
|
| Committer | Ricardo Iván Vieitez Parra |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
|
Interesting, it seems this had no effect on the issue @SebinSong's running into. |
corrideat
force-pushed
the
sebin/task/#2284-upgrade-cypress-to-the-latest-ricardo
branch
from
68e9ddb
to
cb849a9
Compare
SebinSong
reviewed
Sep 8, 2024
Comment on lines
+352
to
+355
| cy.get('@firstRowAmountInput').clear({ force: true }) | ||
| // NOTE: Since this amount input element has a floating element ('$' sign) above it, cypress thinks the <input /> is not visible, which is not true. | ||
| // So we need to add { force: true } here. | ||
| cy.get('@firstRowAmountInput').type('50', { force: true }) |
There was a problem hiding this comment.
I can check if this block can also be replaced with type('{selectall}{del}50') once this PR is merged.
SebinSong
approved these changes
Sep 8, 2024
taoeffect
approved these changes
Sep 8, 2024
taoeffect
deleted the
sebin/task/#2284-upgrade-cypress-to-the-latest-ricardo
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.