Skip to content

Commit

Permalink
Move sed command from build to prebuild
Browse files Browse the repository at this point in the history
The new workflow doesn't run `npm run build` anymore
  • Loading branch information
Zwyx committed Mar 27, 2024
1 parent 3bff14f commit d78d746
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/oxygen-deployment-1000011401.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,6 @@ jobs:
env:
OKENDO_SUBSCRIBER_ID: '${{ secrets.OKENDO_SUBSCRIBER_ID }}'
SHOPIFY_HYDROGEN_DEPLOYMENT_TOKEN: '${{ secrets.OXYGEN_DEPLOYMENT_TOKEN_1000011401 }}'
run: npx shopify hydrogen deploy
run: |
npm run prebuild
npx shopify hydrogen deploy -- --force
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"version": "2.0.1",
"type": "commonjs",
"scripts": {
"build": "sed -i \"s/<your-okendo-subscriber-id>/$OKENDO_SUBSCRIBER_ID/g\" app/root.tsx && shopify hydrogen build",
"prebuild": "sed -i \"s/<your-okendo-subscriber-id>/$OKENDO_SUBSCRIBER_ID/g\" app/root.tsx",
"build": "shopify hydrogen build",
"dev": "shopify hydrogen dev --codegen",
"preview": "npm run build && shopify hydrogen preview",
"lint": "eslint --no-error-on-unmatched-pattern --ext .js,.ts,.jsx,.tsx .",
Expand Down

0 comments on commit d78d746

Please sign in to comment.