Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<OkendoProvider /> attempting to access window in App.server.jsx/tsx #11

Closed
cnr-mtsn opened this issue Jul 28, 2022 · 4 comments
Closed
Assignees

Comments

@cnr-mtsn
Copy link

The Provider appears to be reaching for the window object server-side - in App.server.jsx/tsx - which is causing a build error. Thus, this package only works in development.

@susannepeng
Copy link
Collaborator

susannepeng commented Jul 28, 2022

Hi @cnr-mtsn, I'm unable to reproduce this error in our latest release (v.1.2.0).

Would you mind providing some more information so we can look into this?

  • the version of the package you are on
  • the build error output
  • how you are preparing your application for production:
    • is the prod build you're attempting via a --target node locally, or deploying in to Oxygen?
    • your myshopify url you have Okendo installed on

@cnr-mtsn
Copy link
Author

cnr-mtsn commented Aug 9, 2022

image

Build Error output: here

deploying to Oxygen

moes-test-plus-store.myshopify.com

@owlyowl
Copy link
Collaborator

owlyowl commented Aug 9, 2022 via email

@cnr-mtsn
Copy link
Author

cnr-mtsn commented Aug 9, 2022

Awesome! 😀

@cnr-mtsn cnr-mtsn closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants