-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<OkendoProvider /> attempting to access window
in App.server.jsx/tsx
#11
Comments
Hi @cnr-mtsn, I'm unable to reproduce this error in our latest release (v.1.2.0). Would you mind providing some more information so we can look into this?
|
Build Error output: here deploying to Oxygen moes-test-plus-store.myshopify.com |
Hi Connor,
We've managed to work around the issue.
Looks like react-html-parser references the window object so we've had to
remove that from the OkendoProvider.
We'll have a new release up shortly.
…On Wed, 10 Aug 2022, 3:24 am Conner Matson, ***@***.***> wrote:
[image: image]
<https://user-images.githubusercontent.com/46786879/183717010-138a59a9-269b-439f-90eb-942bea574673.png>
Build Error output: here
<https://pipelines.actions.githubusercontent.com/serviceHosts/6949aabd-7513-4add-a025-a6a8e796f758/_apis/pipelines/1/runs/69/signedlogcontent/2?urlExpires=2022-08-09T17%3A24%3A01.1761338Z&urlSigningMethod=HMACV1&urlSignature=cZ2FkBmwVNaMgDM22WEXfcxqovz%2BUPuL18QcNRPnGBA%3D>
deploying to Oxygen
moes-test-plus-store.myshopify.com
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOT4CWFHBQUEKJDPZUZPYLVYKH5LANCNFSM54553EFA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Awesome! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Provider appears to be reaching for the window object server-side - in App.server.jsx/tsx - which is causing a build error. Thus, this package only works in development.
The text was updated successfully, but these errors were encountered: