-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional header row with letters #436
base: main
Are you sure you want to change the base?
Conversation
guergana
commented
Jun 22, 2024
•
edited
Loading
edited
- fixes Improve datagrid to help the user read errors - Research #429
- fixes Improve datagrid to help the user read errors #441
b690119
to
0a24cf7
Compare
Deploying opendataeditor with
|
Latest commit: |
14b249c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://14f6e2f6.opendataeditor.pages.dev |
Branch Preview URL: | https://429-add-letters-header.opendataeditor.pages.dev |
@guergana we will need to find a way to do |
Thanks for the heads up @pdelboca , I have already wrote a comment to @romicolman to ask what the format will be. But this PR covers the research part I think. :) we could either close this PR and make a new task with the complete changes or maybe continue the task on this PR? To me the format A1, B1 looks more intuitive than AA. But I am not very aware of how this works in other programs. How does excel do it? |
Hi! I created a new ticket to request changes (#441) but we can use this PR for the implementation. If possible, let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. In this sense, since we use numbers for rows, in the error report we can be more specific: errors in cells AA1, B53, etc. |
Ok..thanks for the clarification. :) |
@pdelboca this is the PR where we need to check Frictionless to see to what extent we can tailor the errors report: |
Can be tested with the attached file. Or you can generate one here: https://markbdsouza.github.io/csv-data-generator/ |
Hi! I used the cvs shared in this PR and other csvs to test the change on Mac. It works OK. |