Add additional header row with letters

[guergana]

• fixes Improve datagrid to help the user read errors - Research #429
• fixes Improve datagrid to help the user read errors #441

[cloudflare-workers-and-pages]

Deploying opendataeditor with    Cloudflare Pages

Latest commit:	14b249c
Status:	✅  Deploy successful!
Preview URL:	https://14f6e2f6.opendataeditor.pages.dev
Branch Preview URL:	https://429-add-letters-header.opendataeditor.pages.dev

View logs

[pdelboca]

@guergana we will need to find a way to do AA, AB, AC, AD when having more columns than the alphabet of letters:

[guergana]

@guergana we will need to find a way to do AA, AB, AC, AD when having more columns than the alphabet of letters:

Thanks for the heads up @pdelboca , I have already wrote a comment to @romicolman to ask what the format will be. But this PR covers the research part I think. :) we could either close this PR and make a new task with the complete changes or maybe continue the task on this PR?

To me the format A1, B1 looks more intuitive than AA. But I am not very aware of how this works in other programs. How does excel do it?

[romicolman]

Hi! I created a new ticket to request changes (#441) but we can use this PR for the implementation.

If possible, let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. In this sense, since we use numbers for rows, in the error report we can be more specific: errors in cells AA1, B53, etc.

[guergana]

Hi! I created a new ticket to request changes (#441) but we can use this PR for the implementation.

If possible, let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. In this sense, since we use numbers for rows, in the error report we can be more specific: errors in cells AA1, B53, etc.

Ok..thanks for the clarification. :)

[romicolman]

@pdelboca this is the PR where we need to check Frictionless to see to what extent we can tailor the errors report:
https://framework.frictionlessdata.io/docs/errors/resource.html

[guergana]

Can be tested with the attached file.
CSV_Data_2024_6_24 22 25 many columns.csv

Or you can generate one here: https://markbdsouza.github.io/csv-data-generator/

[romicolman]

Hi! I used the cvs shared in this PR and other csvs to test the change on Mac. It works OK.
@pdelboca Can you check it in Windows?

[pdelboca]

@romicolman @guergana tried on windows and I didn't encounter any error! Works as expected!

I do think that so far it adds more noise than help, so I would make sure that it is possible and feasible to integrate this with other features of ODE so we don't leave this extra metadata without any use (I think the idea is to use this in the report).

[guergana]

@romicolman @guergana tried on windows and I didn't encounter any error! Works as expected!

I do think that so far it adds more noise than help, so I would make sure that it is possible and feasible to integrate this with other features of ODE so we don't leave this extra metadata without any use (I think the idea is to use this in the report).

I agree. We need to test already if this can be integrated in the report because here it is only part of the table rendering. You are absolutely right, @pdelboca I didn't try to add it to the report because @romicolman said these changes will come later..but we need to find a way to at least test if we can send the values..

[romicolman]

Hey! Sorry for my late response. Yes, we are adding because we need it in order to improve the errors report.
The idea is that we can have a proper errors report before the pre-release.

Can we close this PR now? I mean, let's implement the change, please