[WiP] Add top menu to app #557
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
guergana
commented
Sep 22, 2024
guergana
commented
- fixes ODE - Top menu options #417
Deploying opendataeditor with
|
| Latest commit: |
8c37e64
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d806a550.opendataeditor.pages.dev |
| Branch Preview URL: | https://417-top-menu.opendataeditor.pages.dev |
|
I guess to get actual implementation of this you need to pass all the actions and store changes through the electron bridge which is quite a task |
@roll yes, and I am stuck. I would appreciate your help since the code I have currently in this PR is supposed to work but it isn't working 😭 do you have any suggestions of what I might be doing wrong? |
roll
reviewed
Sep 30, 2024
| submenu: [ | ||
| { role: 'about' }, | ||
| { role: 'quit' } | ||
| ] as MenuItemConstructorOptions[] |
There was a problem hiding this comment.
It's better to use type validation instead of type inforcement like:
const template: Electron.MenuItemConstructorOptions[] // or what is correct here
Otherwise using as will silently hide all configuration errors
|
@guergana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.