Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added boolean cells support #565

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Added boolean cells support #565

merged 2 commits into from
Sep 27, 2024

Conversation

roll
Copy link
Collaborator

@roll roll commented Sep 25, 2024


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

@roll roll requested a review from guergana September 25, 2024 10:37
Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 works great.

Still if the user types a value different than true or false in the boolean field, no value is saved. But this belongs in another issue. :)

@roll
Copy link
Collaborator Author

roll commented Sep 27, 2024

@guergana
Thanks!

Yea, exactly. It's about data representations in general. I think we need to create new tickets for displaying custom types of data like booleans, date/times, etc (cc @romicolman). It will restrict a user's ability to input invalid cells and improve UX.

Copy link

cloudflare-workers-and-pages bot commented Sep 27, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2e12ce9
Status: ✅  Deploy successful!
Preview URL: https://c478e89b.opendataeditor.pages.dev
Branch Preview URL: https://292-fix-boolean-field-type.opendataeditor.pages.dev

View logs

@roll roll merged commit 899de5a into main Sep 27, 2024
5 checks passed
@roll roll deleted the 292/fix-boolean-field-type branch September 27, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with new field of type boolean
2 participants