Skip to content
This repository has been archived by the owner on Apr 11, 2022. It is now read-only.

UI bugs for 2015 Index #124

Open
4 of 6 tasks
morchickit opened this issue Nov 10, 2015 · 11 comments
Open
4 of 6 tasks

UI bugs for 2015 Index #124

morchickit opened this issue Nov 10, 2015 · 11 comments
Assignees
Milestone

Comments

@morchickit
Copy link
Contributor

  • Names of datasets are cutting in Safari in places display.
    screen shot 2015-11-10 at 17 30 15

All ok on Chrome

  • Remove Health Performance and Public Transport from Places page - http://2015.index.okfn.org/place/
  • Names of some countries are cut in the display of places page http://2015.index.okfn.org/place/ - See image -
    screen shot 2015-11-10 at 18 09 46
  • Hover over the name of the dataset in places view is broken and shows the HTML as well
    screen shot 2015-11-19 at 09 08 59
  • It's really hard to differ between green and yellow on the new map implementation.
  • Map still shows countries that are not in the Index:
    Zimbabwe, New Zealand, Cyprus, Zambia, Lesotho, Uganda, Yemen, Ghana, Peru, Haiti, Venezuela, Sierra Leon, Bangladesh, Poland, Belarus, Slovenia, Croatia, Bosnia
@pwalsh
Copy link
Member

pwalsh commented Nov 10, 2015

@morchickit can i suggest you collect any and all UI issues in this ticket, and not open separate ones. Then we'll have a single ticket for data issues, and a single ticket for UI issues.

@pwalsh pwalsh changed the title Datasets names cut or not displayed in Safari UI bugs for 2015 Index Nov 10, 2015
@morchickit
Copy link
Contributor Author

I was looking for a UI/UX ticket and couldn't find it. Let's keep this one.

@pwalsh
Copy link
Member

pwalsh commented Nov 17, 2015

@morchickit first issue is for Sam, and not ui implementation. Second issue: we have an uncustomised polygon of the world - it shows a bunch of countries we maybe don't have data for.

@morchickit
Copy link
Contributor Author

@pwalsh - let me be more clear about the second one - it color the countries that don't have data this year. i.e - New Zealand is marked in red instead of grey.
@smth - can you please look at the colours issue?

@smth
Copy link
Contributor

smth commented Nov 17, 2015

I'm assuming the green / yellow issue is an effect of the black background (that's all that's changed, right?). The new design reverts this change, and so should resolve that issue.

@pwalsh
Copy link
Member

pwalsh commented Nov 18, 2015

@morchickit

  • Name of some countries cut: it fits in the room we have. Any alternative would need a design solution from @smth unless there is an implementation error here for the new table design

@pwalsh pwalsh added this to the Current milestone Nov 18, 2015
@smth
Copy link
Contributor

smth commented Nov 18, 2015

I'd say it's more an implementation error. There should be room for those labels. The coloured bars should reduce in width as required, as far as the dataset labels allow. For smaller screens, there should be scrolling which behaves like this http://www.heldercervantes.com/sexytables/

@pwalsh
Copy link
Member

pwalsh commented Nov 18, 2015

@smth ok great. So, on Census, the place name cell is at 147px width. You think we should do that here?

@smth
Copy link
Contributor

smth commented Nov 18, 2015

Yes, I was about to add that some less than ideal code would probably be required to get this to work, i.e a fixed width on that column. (I see that the scrolling is already in place too).

@pwalsh
Copy link
Member

pwalsh commented Nov 23, 2015

@roll please check the issue about the map at the top of the thread.

roll pushed a commit that referenced this issue Nov 25, 2015
@roll
Copy link

roll commented Nov 25, 2015

Updated Index is online - http://2015.index.okfn.org/ (fixed countries on map)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants