Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koala JavaScript compressor will remove copyrights #312

Closed
julkue opened this issue Oct 28, 2014 · 5 comments
Closed

Koala JavaScript compressor will remove copyrights #312

julkue opened this issue Oct 28, 2014 · 5 comments

Comments

@julkue
Copy link

julkue commented Oct 28, 2014

UglifyJS in Koala removes copyright informations. Just remove comments is great but in fact it will also remove comments like that:

/*!
  this comment will not be removed by minifiers
 */
@julkue
Copy link
Author

julkue commented Oct 29, 2014

I want to make sure that this a important bug since you have to add the copyright manually to each file. This is the opposite of automation..

@oklai
Copy link
Owner

oklai commented Nov 18, 2014

I agree with you, it should preserve copyright comments in the output. And UglifyJS has a option for this.

@julkue
Copy link
Author

julkue commented Nov 18, 2014

Will you add this option to the GUI?

@oklai
Copy link
Owner

oklai commented Nov 18, 2014

Yes, I will add it.
2014年11月18日 下午1:35于 "julmot" notifications@github.com写道:

Will you add this option i the GUI?


Reply to this email directly or view it on GitHub
#312 (comment).

@julkue
Copy link
Author

julkue commented Dec 6, 2014

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants