-
-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(example): patch create-react-app 4.0
due to 9921 is not released yet (facebook/create-react-app#9921)
- Loading branch information
Showing
5 changed files
with
110 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,11 @@ | ||
| # Getting Started with Create React App | ||
| # Demo | ||
|
|
||
| This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). | ||
| ## react-scripts patched | ||
|
|
||
| ## Available Scripts | ||
| Patched due to [create-react-app #9921](https://github.com/facebook/create-react-app/pull/9921) not yet released | ||
| Wait for any crete-react-app version above 4.0 | ||
| after upgrade - remove **appropriate** patches | ||
| If no any more patches: | ||
| * remove deps: patch-package postinstall-postinstall | ||
| * remove "postinstall": "patch-package" from "scripts" (package.json) | ||
|
|
||
| In the project directory, you can run: | ||
|
|
||
| ### `yarn start` | ||
|
|
||
| Runs the app in the development mode.\ | ||
| Open [http://localhost:3000](http://localhost:3000) to view it in the browser. | ||
|
|
||
| The page will reload if you make edits.\ | ||
| You will also see any lint errors in the console. | ||
|
|
||
| ### `yarn test` | ||
|
|
||
| Launches the test runner in the interactive watch mode.\ | ||
| See the section about [running tests](https://facebook.github.io/create-react-app/docs/running-tests) for more information. | ||
|
|
||
| ### `yarn build` | ||
|
|
||
| Builds the app for production to the `build` folder.\ | ||
| It correctly bundles React in production mode and optimizes the build for the best performance. | ||
|
|
||
| The build is minified and the filenames include the hashes.\ | ||
| Your app is ready to be deployed! | ||
|
|
||
| See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. | ||
|
|
||
| ### `yarn eject` | ||
|
|
||
| **Note: this is a one-way operation. Once you `eject`, you can’t go back!** | ||
|
|
||
| If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | ||
|
|
||
| Instead, it will copy all the configuration files and the transitive dependencies (webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. | ||
|
|
||
| You don’t have to ever use `eject`. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it. | ||
|
|
||
| ## Learn More | ||
|
|
||
| You can learn more in the [Create React App documentation](https://facebook.github.io/create-react-app/docs/getting-started). | ||
|
|
||
| To learn React, check out the [React documentation](https://reactjs.org/). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| diff --git a/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js | ||
| index 00139ee..dd0932e 100644 | ||
| --- a/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js | ||
| +++ b/node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js | ||
| @@ -148,7 +148,7 @@ function verifyTypeScriptSetup() { | ||
| jsx: { | ||
| parsedValue: | ||
| hasJsxRuntime && semver.gte(ts.version, '4.1.0-beta') | ||
| - ? ts.JsxEmit.ReactJsx | ||
| + ? ts.JsxEmit.ReactJSX // wait for create-react-app above 4.0 released (then remove patch) | ||
| : ts.JsxEmit.React, | ||
| value: | ||
| hasJsxRuntime && semver.gte(ts.version, '4.1.0-beta') | ||
| @@ -218,6 +218,15 @@ function verifyTypeScriptSetup() { | ||
| if (appTsConfig.compilerOptions == null) { | ||
| appTsConfig.compilerOptions = {}; | ||
| firstTimeSetup = true; | ||
| + } else { | ||
| + // wait for create-react-app above 4.0 released (then remove patch) | ||
| + // This is bug fix code of https://github.com/facebook/create-react-app/issues/9868 | ||
| + // Bellow code release variable from non-extensible and freeze status. | ||
| + appTsConfig.compilerOptions = JSON.parse(JSON.stringify(appTsConfig.compilerOptions)); | ||
| + | ||
| + // Original appTsConfig.compilerOptions status | ||
| + // Object.isExtensible(appTsConfig.compilerOptions) output: false | ||
| + // Object.isFrozen(appTsConfig.compilerOptions) output: true | ||
| } | ||
|
|
||
| for (const option of Object.keys(compilerOptions)) { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters