Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA 4.0 support? #9

Closed
xinghul opened this issue Oct 27, 2020 · 5 comments
Closed

CRA 4.0 support? #9

xinghul opened this issue Oct 27, 2020 · 5 comments

Comments

@xinghul
Copy link

xinghul commented Oct 27, 2020

Hi there, not entirely sure what's happening, I tried to upgrade to CRA 4.0, but I got this error:

node_modules/react-scripts/scripts/utils/verifyTypeScriptSetup.js:241
      appTsConfig.compilerOptions[option] = value;
                                          ^

TypeError: Cannot add property paths, object is not extensible
@xinghul
Copy link
Author

xinghul commented Oct 27, 2020

nvm, this is irrelevant.

@xinghul xinghul closed this as completed Oct 27, 2020
@oklas
Copy link
Owner

oklas commented Nov 20, 2020

Hi, @xinghul, why did you closed as irrelevant? Write your thoughts or problem more detailed to let people know what they can experienced and how to solve. It save time for many people.

Hi, @nvt1995-dev also provide your experience here.

Also relevant issue: create-react-app #9429 - I will see if will have time.

Also use create-react-app 4.0 will impossible without this pull create-react-app #9921 - int is merged but not released - so wait when any create-react-app version above 4.0 will be released (or get patch manually using patch-package).

It is actual - so I reopen issue

@oklas oklas reopened this Nov 20, 2020
@xinghul
Copy link
Author

xinghul commented Nov 20, 2020

@oklas I digged into the code and realized it's an issue with CRA 4.0.

@oklas
Copy link
Owner

oklas commented Nov 21, 2020

The pull create-react-app #9921 is merged but not released yet. Currently that is the only thing is blocking to work.

Here the commit 600ffb4 (on example project) to demonstrate how to apply manually patch for 9921 using patch-package.

Form outside of root TS does not see libraries, but JS works. In the root (near src) TS works.

Docs also actualised to simplify usage.

@oklas
Copy link
Owner

oklas commented Nov 21, 2020

Currently problem does not concern react-app-rewire-alias and it will be worked with next release of create-react-app (or with previous) or with mentioned above patch. So I close this for now. Anyone feel free to write or reopen if any. Subscribe news at twitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants