Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to mention v2 #48

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Update README to mention v2 #48

merged 2 commits into from
Jun 3, 2019

Conversation

lmas
Copy link
Contributor

@lmas lmas commented May 20, 2019

Was having a problem trying to get a *MonotonicEntropy from Monotonic(), before I realized it was in v2 (while I had the old 1.3 installed).

Might want to add a bigger notice about using v2 instead?

@coveralls
Copy link

coveralls commented May 20, 2019

Coverage Status

Coverage increased (+0.02%) to 97.959% when pulling e02e999 on lmas:patch-1 into be3bccf on oklog:master.

Copy link
Contributor

@tsenart tsenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbourgon
Copy link
Member

Oh, sorry; I didn't know the badge had to be updated manually. Could you try to use the auto-updating version? In HTML:

<a href="https://github.com/oklog/ulid/releases/latest">
 <img src="https://img.shields.io/github/release/oklog/ulid.svg?style=flat-square"/>
</a>

@peterbourgon
Copy link
Member

@lmas Would you mind updating the badge to use the auto-updating version as above? I can try to dig up the Markdown version, if that's blocking you.

@lmas
Copy link
Contributor Author

lmas commented Jun 2, 2019

@peterbourgon gotcha

@peterbourgon
Copy link
Member

Thanks!

@peterbourgon peterbourgon merged commit e51a56f into oklog:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants