-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ulid: add DefaultEntropy() and Make() #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users of this library have opened many issues regarding the difficulty of choosing an entropy source that is safe for concurrent use.
This commit introduces a thread safe per process monotonically increase `DefaultEntropy()` function as well as an easy to use `Make()` function, aimed at users that want safe defaults chosen for them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Round 1.
peterbourgon
force-pushed
the
ts/default-entropy
branch
from
June 22, 2022 15:23
375c4ee
to
1e6a349
Compare
@peterbourgon Could you tag this for a new release? |
@ganigeorgiev Check out v2.1.0-alpha.1 and gimme some feedback :) |
@peterbourgon package main
import (
"fmt"
"github.com/oklog/ulid/v2"
)
func main() {
fmt.Printf("ulid.Make(): %s\n", ulid.Make())
} $ go get github.com/oklog/ulid/v2@v2.1.0-alpha.1
go: upgraded github.com/oklog/ulid/v2 v2.0.2 => v2.1.0-alpha.1
$ go run main.go
ulid.Make(): 01G7MSBEWS6WMSTABGZQ8W5W3S |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a thread safe per process monotonically increase
DefaultEntropy()
function as well as an easy to use
Make()
function, aimed at usersthat want safe defaults chosen for them.