fix: Prevent component from being updated after it gets unmounted (#49)

Prevents container dimensions from being updated after it gets unmounted Fixes #48
okonet · Jun 15, 2018 · ff18f61 · ff18f61
1 parent 649ca20
commit ff18f61
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/index.js b/src/index.js
@@ -30,19 +30,23 @@ export default class ContainerDimensions extends Component {
       callOnAdd: false
     })
     this.elementResizeDetector.listenTo(this.parentNode, this.onResize)
+    this.componentIsMounted = true
     this.onResize()
   }
 
   componentWillUnmount() {
+    this.componentIsMounted = false
     this.elementResizeDetector.uninstall(this.parentNode)
   }
 
   onResize() {
     const clientRect = ContainerDimensions.getDomNodeDimensions(this.parentNode)
-    this.setState({
-      initiated: true,
-      ...clientRect
-    })
+    if (this.componentIsMounted) {
+      this.setState({
+        initiated: true,
+        ...clientRect
+      })
+    }
   }
 
   render() {