Set callOnAdd: false option of the detector #15
Conversation
|
What GHI should this fix? |
|
What is GHI? |
|
@ValentinH GitHub Issue :) |
|
There is no issue open directly referring to this PR. However, the false-positive test in #9 was due to This is more about optimization because I don't see the point of having |
|
Awesome! Thanks 🙏 |
| @@ -49,15 +49,15 @@ describe('react-container-dimensions', () => { | |||
| ContainerDimensions.prototype.onResize.restore() | |||
| }) | |||
|
|
|||
| it('calls onResize when parent has been resized', (done) => { | |||
| xit('calls onResize when parent has been resized', (done) => { | |||
There was a problem hiding this comment.
Oh I see you skipped the test completely. I though this will fix it. Am I missing something?
There was a problem hiding this comment.
Actually, the test was passing for wrong reasons because it was a false positive. Now with my PR, the test fails.
I have tried to fix it but couldn't manage to send the resize event to the detector in JSDom. I think you mentioned that in another PR of mine, I'm not sure it's doable with JSDom.
There was a problem hiding this comment.
Okay, makes sense. I'll remove the test for now then.
There was a problem hiding this comment.
IMO it would be better to keep it so it's not forgotten! 😄
There was a problem hiding this comment.
Yeah, decided to keep it :) Thanks!
As discussed in #9, I set the
callOnAdd : falseoption on the detector to preventonResize()to be called twice.However, I have excluded the resize test because it was failing (it was passing before, but it was a false positive) and I couldn't manage to trigger the resize from test...