Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid exposing internal state initiated #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid exposing internal state initiated #58

wants to merge 2 commits into from

Conversation

franklixuefei
Copy link
Contributor

No description provided.

@franklixuefei
Avoid exposing internal state initiated
d11a0ca 
Avoid exposing internal state `initiated`
@franklixuefei
fix
30744f6
@okonet
Copy link
Owner

okonet commented Nov 17, 2018

Can you also update tests?

okonet
okonet requested changes Nov 17, 2018
View reviewed changes
Copy link
Owner

@okonet okonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI has failed. Please check it out.

@okonet
Copy link
Owner

okonet commented Nov 17, 2018

One more thing to think about: initiated should not probably be in the state at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okonet okonet okonet requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@franklixuefei @okonet