Transactional rename on Windows #355
Conversation
mehrdadn
force-pushed
the
txf
branch
2 times, most recently
from
1cbb633 to
cadaa7e
Compare
client/sources/ok_test/models.py
Outdated
| success = True | ||
| except (NotImplementedError, OSError): | ||
| pass | ||
| if not success: |
There was a problem hiding this comment.
Would it make sense for this block to be inside the body of the except clause and the success = False; success = True bit go away.
There was a problem hiding this comment.
Sure I could do that if you'd like. The reason behind this was that I've gotten burned before in Python 2 when raising exceptions from except blocks, so I try to avoid it just in case it becomes an issue again (not sure if it's entirely fixed in Python 3 but I try to write code that'd work in Python 2 too).
There was a problem hiding this comment.
ok-client should be python3 only, but I'm curious about that issue. There are issues raising different exceptions in an except block in python2?
There was a problem hiding this comment.
Yup! What would Python print? :-)
try:
try: raise ValueError("ValueError")
except:
try: raise NotImplementedError("NotImplementedError")
except: pass
raise
except Exception as ex: print(ex)
There was a problem hiding this comment.
Okay I just removed success, see the updated code.
There was a problem hiding this comment.
Oh I just realized I don't raise NotImplementedError properly... let me fix that.
mehrdadn
force-pushed
the
txf
branch
2 times, most recently
from
f2955d6 to
6dda3d6
Compare
No description provided.