Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on osx #399

Merged
merged 5 commits into from
Dec 27, 2019
Merged

Test on osx #399

merged 5 commits into from
Dec 27, 2019

Conversation

kavigupta
Copy link
Contributor

No description provided.

@kavigupta kavigupta changed the title try 1 at making it work with osx Test on osx Dec 26, 2019
mehrdadn
mehrdadn approved these changes Dec 27, 2019
View reviewed changes
Copy link
Contributor

@mehrdadn mehrdadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe pick either source or ., right now you have both. I think . is more portable?

@kavigupta kavigupta merged commit 0536855 into master Dec 27, 2019
@kavigupta kavigupta deleted the osx-tests branch December 27, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehrdadn mehrdadn mehrdadn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavigupta @mehrdadn