-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Github Actions #402
Conversation
510453a
to
fa383bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kavigupta I switched from Travis to GitHub Actions; it seems to have fewer headaches to deal with.
Can you verify that it's testing everything it's supposed to (and otherwise doing fine), and if so, delete the merge requirement for Travis (and add one for GitHub Actions instead)?
You're going to need to get @Sumukh or @colinschoen to lgtm, I don't feel entirely comfortable making this global of a change without approval |
This seems quite a bit faster and a bit cleaner! The one thing I think it's missing is the slack integration but I'm not confident that even worked before since I don't remember getting any slack notifications about okpy |
Wait why are there 12 tests? are they randomly placed either on Actually, wait there's 16 tests? How does that add up? |
Yeah I took out the Slack integration because it seemed to be already useless. |
yeah the Labelling is probably unnecessary, if there's an error we can just click through Linux seems to be missing, which is fine I guess (it's pretty covered by osx and not actually used much) but it would be ideal if we had it |
It's easy to add, I can add it. |
thanks! |
bedcee6
to
a094646
Compare
a094646
to
2d29813
Compare
2d29813
to
945c56c
Compare
@kavigupta ok done. I also named them explicitly since it was kind of annoying to discover the versions otherwise. |
They are a bit faster and significantly more stable