chore(odyssey-react): add text component to tooltip #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +55,9 @@ let Tooltip = forwardRef<HTMLElement, TooltipProps>((props, ref) => { | |||
| className={tooltipClasses} | |||
| role="tooltip" | |||
| > | |||
| {label} | |||
| <Text color="bodyInverse" size="caption" weight="bold"> | |||
There was a problem hiding this comment.
These styles should be removed from the module, right?
There was a problem hiding this comment.
Good catch, I accidentally stashed this work and didn't commit/push it up. Fixing.
edburyenegren-okta
approved these changes
Nov 10, 2021
arnoldsandoval-okta
added a commit
that referenced
this pull request
Nov 18, 2021
* chore(odyssey-react): add text component to tag (#1169) * chore(odyssey-react): add text component to infobox (#1171) * feat(odyssey-react): Text component refactor in Banner (#1160) * feat(odyssey-react): refactor Banner to use Text component. Add default font family to Heading * chore(odyssey-react): add semantic tag back in for banner * chore(odyssey-storybook): remove deprecated global styles from storybook * Revert "chore(odyssey-storybook): remove deprecated global styles from storybook" This reverts commit 247e5f0. * Add documentation template (#1166) * docs: added documentation template for contributors * chore(odyssey-react): fix Form type annotation and improve Toast.Provider story (#1175) * chore(odyssey-react): fix type annotations for form * chore(odyssey-react): use odyssey form component in Toast.Provider story * chore(odyssey-react): use relative path for form import in toast story * chore(odyssey-react): add text component to tooltip (#1170) * chore(odyssey-react): add text component to tooltip * chore(odyssey-react): remove text css for tooltip * build: use conventional commits for changelog and lint * test(odyssey-react): add coverage for controlled Select * refactor(odyssey-react): use Text for List * feat: support async select options * feat: expose hidden choices reference * fix: lint * fix: remove added dep / prop * fix: updates per review feedback * fix: type issue need cast to force union start type when using callback * fix: controlled select case by using to ref.current * docs: adds an Odyssey theme for Storybook (#1183) * docs(odyssey-storybook): adds an Odyssey theme for Storybook * docs(odyssey-storybook): updates contribution guidelines * fix(odyssey-design-tokens): call "value" instead of whole objects * build(odyssey-design-tokens): add prepare script * build(odyssey-design-tokens): add stylelint config to ignore dist Co-authored-by: Arnold Sandoval <62259644+arnoldsandoval-okta@users.noreply.github.com> Co-authored-by: Jeff Belser <63716167+jeffbelser-okta@users.noreply.github.com> * refactor(odyssey-react): move related types into useChoices module * docs: adds an Odyssey theme for Storybook (#1183) * docs(odyssey-storybook): adds an Odyssey theme for Storybook * docs(odyssey-storybook): updates contribution guidelines * fix(odyssey-design-tokens): call "value" instead of whole objects * build(odyssey-design-tokens): add prepare script * build(odyssey-design-tokens): add stylelint config to ignore dist Co-authored-by: Arnold Sandoval <62259644+arnoldsandoval-okta@users.noreply.github.com> Co-authored-by: Jeff Belser <63716167+jeffbelser-okta@users.noreply.github.com> * build: bump versions for v0.8.4 * docs: update CHANGELOG for v0.8.4 Co-authored-by: Edbury Enegren <edbury.enegren@okta.com> Co-authored-by: Jeff Belser <63716167+jeffbelser-okta@users.noreply.github.com> Co-authored-by: MACY ABBEY <macy.abbey@okta.com>
arnoldsandoval-okta
added a commit
that referenced
this pull request
Nov 19, 2021
* chore(odyssey-react): add text component to tag (#1169) * chore(odyssey-react): add text component to infobox (#1171) * feat(odyssey-react): Text component refactor in Banner (#1160) * feat(odyssey-react): refactor Banner to use Text component. Add default font family to Heading * chore(odyssey-react): add semantic tag back in for banner * chore(odyssey-storybook): remove deprecated global styles from storybook * Revert "chore(odyssey-storybook): remove deprecated global styles from storybook" This reverts commit 247e5f0. * Add documentation template (#1166) * docs: added documentation template for contributors * chore(odyssey-react): fix Form type annotation and improve Toast.Provider story (#1175) * chore(odyssey-react): fix type annotations for form * chore(odyssey-react): use odyssey form component in Toast.Provider story * chore(odyssey-react): use relative path for form import in toast story * chore(odyssey-react): add text component to tooltip (#1170) * chore(odyssey-react): add text component to tooltip * chore(odyssey-react): remove text css for tooltip * build: use conventional commits for changelog and lint * test(odyssey-react): add coverage for controlled Select * refactor(odyssey-react): use Text for List * feat: support async select options * feat: expose hidden choices reference * fix: lint * fix: remove added dep / prop * fix: updates per review feedback * fix: type issue need cast to force union start type when using callback * fix: controlled select case by using to ref.current * docs: adds an Odyssey theme for Storybook (#1183) * docs(odyssey-storybook): adds an Odyssey theme for Storybook * docs(odyssey-storybook): updates contribution guidelines * fix(odyssey-design-tokens): call "value" instead of whole objects * build(odyssey-design-tokens): add prepare script * build(odyssey-design-tokens): add stylelint config to ignore dist Co-authored-by: Arnold Sandoval <62259644+arnoldsandoval-okta@users.noreply.github.com> Co-authored-by: Jeff Belser <63716167+jeffbelser-okta@users.noreply.github.com> * refactor(odyssey-react): move related types into useChoices module * docs: adds an Odyssey theme for Storybook (#1183) * docs(odyssey-storybook): adds an Odyssey theme for Storybook * docs(odyssey-storybook): updates contribution guidelines * fix(odyssey-design-tokens): call "value" instead of whole objects * build(odyssey-design-tokens): add prepare script * build(odyssey-design-tokens): add stylelint config to ignore dist Co-authored-by: Arnold Sandoval <62259644+arnoldsandoval-okta@users.noreply.github.com> Co-authored-by: Jeff Belser <63716167+jeffbelser-okta@users.noreply.github.com> * build: bump versions for v0.8.4 * docs: update CHANGELOG for v0.8.4 Co-authored-by: Edbury Enegren <edbury.enegren@okta.com> Co-authored-by: Jeff Belser <63716167+jeffbelser-okta@users.noreply.github.com> Co-authored-by: MACY ABBEY <macy.abbey@okta.com> Co-authored-by: Edbury Enegren <edbury.enegren@okta.com> Co-authored-by: Jeff Belser <63716167+jeffbelser-okta@users.noreply.github.com> Co-authored-by: MACY ABBEY <macy.abbey@okta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.