-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added nonce capability for legacy Odyssey #1540
Conversation
@KevinGhadyani-Okta did you happen to look at the inline style assignment here? I'm not 100% certain this will be a CSP violation because of how I recall JSX compiling HTML attributes to JS property assignment as sugar but I could be wrong! cc @conorhanrahan-okta not sure if you're looked into this issue specifically for React/JSX yet? |
I haven't looked into it but I imagine there is a React solution that does it in a CSP safe way. If it's not happening already there is probably a plugin or configuration setting that would turn that into CSP safe |
@conorhanrahan-okta @KevinGhadyani-Okta here are some more links. It's clear to me that React passes prop values as HTML attributes to custom elements but that isn't in play here. https://custom-elements-everywhere.com/ (scroll down to React section) |
Is this the only warning produced by odyssey? Or are there more warnings to be fixed in other tickets? |
I noticed an issue from |
Tested this in Monolith using existing libraries from Okta-UI-React as well as testing in Okta-UI-React's dev playground. We're good. |
Description
Added a connection for legacy Odyssey apps to utilize a nonce.