Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icon: user group #1559

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Add Icon: user group #1559

merged 3 commits into from
Aug 31, 2022

Conversation

edburyenegren-okta
Copy link
Contributor

Description

  • Adds user-group.svg to @okta/odyssey-icons
  • Adds UserGroupIcon to @okta/odyssey-react-mui

Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How'd you get this to run?

@edburyenegren-okta
Copy link
Contributor Author

@KevinGhadyani-Okta the steps are:

  1. Add asset from Figma to figma/
  2. Run yarn svgo within @okta/odyssey-icons
  3. Run yarn build:icons from root
  4. Add icons to Storybook

I'll open a docs PR to add a full example to our "Contributing" page, so we don't get lost in the future.

@edburyenegren-okta edburyenegren-okta merged commit f23d5a6 into develop Aug 31, 2022
@edburyenegren-okta edburyenegren-okta deleted the ee/icon-user-group branch August 31, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants