fix: upgraded Jest to v29 #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGhadyani-Okta
requested review from
a team,
ganeshsomasundaram-okta and
kamronbatmanghelich-okta
as code owners
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-481893
branch
from
5eef0a9 to
3872c7e
Compare
kamalgill-okta
suggested changes
Sep 20, 2022
| } | ||
| return true; | ||
| }); | ||
| const focusableItems = Array.from(allItems).filter((el) => el.tabIndex >= 0); |
There was a problem hiding this comment.
Aren't there focusable elements (such as buttons) that don't need an explicit tabindex attribute?
There was a problem hiding this comment.
Feel free to ignore this comment given the relevant code wasn't modified in this PR, but we should probably at some point improve the focusableItems lookup to account for elements that are natively focusable without requiring a tabindex attribute.
kamronbatmanghelich-okta
approved these changes
Sep 20, 2022
KevinGhadyani-Okta
force-pushed
the
kg/OKTA-481893
branch
from
50687c3 to
573a9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded Jest to v29.