Style Autocomplete #1725
Merged
Style Autocomplete #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edburyenegren-okta
requested review from
a team,
ganeshsomasundaram-okta,
KevinGhadyani-Okta and
kamronbatmanghelich-okta
as code owners
edburyenegren-okta
changed the title
edburyenegren-okta
force-pushed
the
ee/autocomplete
branch
from
b80ddd3 to
cd297cb
Compare
packages/odyssey-storybook/src/components/odyssey-mui/Autocomplete/Autocomplete.stories.tsx
Outdated
Show resolved
Hide resolved
edburyenegren-okta
changed the title
This doesn't actually fix MUI types, but it passes enough to push it.
KevinGhadyani-Okta
force-pushed
the
ee/autocomplete
branch
from
a3585cc to
ab84734
Compare
KevinGhadyani-Okta
force-pushed
the
ee/autocomplete
branch
from
155c944 to
8d28a8c
Compare
edburyenegren-okta
changed the title
Comment on lines
+593
to
+595
| [`.${inputBaseClasses.root}.${inputBaseClasses.disabled} &`]: { | ||
| backgroundColor: theme.palette.grey[200], | ||
| }, |
There was a problem hiding this comment.
I'm assuming we won't have to use grey[200] with Design Tokens v2 right?
There was a problem hiding this comment.
Yup. We don't have a token for it currently, but I'll be doing replacements with the new schema.
Comment on lines
-71
to
-74
| ## Props | ||
|
|
||
| <ArgsTable /> | ||
|
|
There was a problem hiding this comment.
Did you mean to remove this?
There was a problem hiding this comment.
Yup; in our current setup, these don't display anything. We had removed it from most files, but this one was lingering.
KevinGhadyani-Okta
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Styling and stories for Autocomplete.