-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isOptional to Checkbox #1773
Conversation
|
Ah, here's the WIP PR I was thinking of: #1762 |
Okay, excellent, I can redo this based on the I don't think there's an elegant way of indicating "optional" on a single checkbox, especially since the vast majority of checkboxes will be optional — any thoughts on this? |
I made some changes:
|
packages/odyssey-storybook/src/components/odyssey-mui/Checkbox/Checkbox.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR's ready to go, but now we need to integrate with the translation code.
This PR adds
isOptional
toCheckbox
. In order to make this happen, I needed to use therequired
prop onFormControlLabel
, which necessitated updating to the latest MUI.