-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globalization enhancements #1791
Conversation
d9cd242
to
e158c22
Compare
c273fa0
to
7bd9818
Compare
The following keys can have their values overriden: | ||
|
||
- `fielderror.screenreader.text` | ||
- `fieldlabel.optional.text` | ||
- `severity.success` | ||
- `severity.warning` | ||
- `severity.info` | ||
- `severity.error` | ||
- `toast.close.text` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice we document these, but can we generate this from the TS instead?
I think we can do a loop from the .ts
files; that way if we add one, no one has to remember to update the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would mean moving from simple markdown stories to a tsx one. Will see if I have time by eod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mdx
files allow you to write JavaScript.
I'll set this to NON-BLOCKING. Just make a ticket for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you can only render "JSX" components
7bd9818
to
f6f9d5e
Compare
f6f9d5e
to
a1047b6
Compare
a1047b6
to
cb6fbe4
Compare
Description
OdysseyTranslationProvider
andOdysseyProvider
can taketranslationOverrides
prop in to optionally override key/value pairs for any language that is supported as follow:fs-extra
, everything could be reimplemented withfs
directly.