Rebrand: Link #1811
Merged
Rebrand: Link #1811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edburyenegren-okta
requested review from
a team,
ganeshsomasundaram-okta,
KevinGhadyani-Okta and
kamronbatmanghelich-okta
as code owners
taylorridgway-okta
approved these changes
Jun 1, 2023
ganeshsomasundaram-okta
approved these changes
Jun 2, 2023
| }, | ||
| svg: { | ||
| fontSize: "1rem", |
There was a problem hiding this comment.
How does this change look effectively? It inherits the parent's size?
There was a problem hiding this comment.
It's identical, since the font-size on the parent is 1rem, but now the icon will scale if that changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link
Linkstyles to match the latest designsLinkvariables to use Odyssey tokensTokens
palette.primary.darkerand remapsdarkto700typography.color.primarytotypography.color.actionfor clarity on use caseTypography
colorproperties to all headings and body styles