Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TagList can wrap #1837

Merged
merged 4 commits into from
Jul 5, 2023
Merged

Ensure TagList can wrap #1837

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b34cfe
fix: ensure TagList can wrap
jordankoschei-okta Jun 13, 2023
4cfde43
feat: add isWrappable to TagList
jordankoschei-okta Jun 13, 2023
e8e6908
refactor: make flexWrap the default
jordankoschei-okta Jun 21, 2023
d7d5777
Merge branch 'develop' into jk/OKTA-618614
jordankoschei-okta Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/odyssey-react-mui/src/TagList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,13 @@ const TagList = ({ children }: TagListProps) => {
);

return (
<Stack component="ul" direction="row" spacing={2}>
<Stack
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinGhadyani-Okta here's another place where having our own class names accessible would be helpful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinGhadyani-Okta direction and spacing here are both CSS properties being applied via sx -- basically using a style attribute rather than via components.ts or another style layer. We have the same problem with Form and Fieldset.

Nothing wrong with this PR, but we should find a solution that makes our styling application consistent across components.

component="ul"
direction="row"
spacing={2}
useFlexGap
flexWrap="wrap"
>
<TagListContext.Provider value={providerValue}>
{children}
</TagListContext.Provider>
Expand Down