Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap Typography #1886
Wrap Typography #1886
Changes from 1 commit
806b9e4
a73be08
2f81f22
4ace733
de4912e
6dd4a55
0c7de35
5017d68
bf5ce00
a878618
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the result of some cleverness in MUI that makes things more difficult for us.
We want to allow consumers to change the
component
prop independently of thevariant
. Thecomponent
prop, strangely, is required in this implementation. It can't be undefined.This conditional does the following:
component
is explicitly defined, move oncomponent
tovariant
variant
is one of the two possibilities that doesn't map directly to an HTML element, set thecomponent
manuallyIt's ugly, it's brute-force, and it gets the job done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To throw another wrench in: we should probably alias the
body
variant to<P>
for consistency, since<body>
has a very different use.<Caption>
is also a little 😬 because<caption>
is a<table>
-only element in HTML.I'm in favor of this pattern, but it might start to feel limiting for some folks.