fix(odyssey-react-mui): ensure headings pick up TypographyFamilyHeading #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edburyenegren-okta
requested review from
ganeshsomasundaram-okta,
KevinGhadyani-Okta,
kamronbatmanghelich-okta and
a team
as code owners
KevinGhadyani-Okta
approved these changes
Aug 22, 2023
Comment on lines
-2274
to
-2275
| fontFamily: | ||
| "'Inter', '-apple-system', 'BlinkMacSystemFont', 'Segoe UI', 'Roboto', 'Oxygen-Sans', 'Ubuntu', 'Cantarell', 'Helvetica Neue', 'Noto Sans Arabic', sans-serif", |
There was a problem hiding this comment.
We don't need these? Or was this the situation it had the wrong font?
There was a problem hiding this comment.
Setting the default here unintuitively overrides the styles in typography.ts. They've probably been broken for awhile 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typographyvariants no longer have theirfontFamilyoverridden by a default prop.supportandsubordinatenow render aspinstead ofh6.