Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

English leak for "Close" in Autocomplete #2291

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

stephanieyoshimoto-okta
Copy link
Contributor

OKTA-742635

Summary

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

Before:
Screenshot 2024-07-12 at 11 25 47 AM

Now:
Screenshot 2024-07-12 at 11 23 24 AM

@stephanieyoshimoto-okta stephanieyoshimoto-okta requested a review from a team as a code owner July 15, 2024 22:37
@stephanieyoshimoto-okta stephanieyoshimoto-okta changed the title Autocomplete tooltips English leak for "Close" in Autocomplete Jul 15, 2024
Copy link
Contributor

@bryancunningham-okta bryancunningham-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for adding this!

@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 5a0ed91 into main Jul 18, 2024
1 of 2 checks passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the OKTA-742653 branch July 18, 2024 20:11
bryancunningham-okta pushed a commit that referenced this pull request Jul 25, 2024
OKTA-742653 English leak for "Close" in Autocomplete
bryancunningham-okta pushed a commit that referenced this pull request Jul 25, 2024
OKTA-742653 English leak for "Close" in Autocomplete
oktapp-aperture-okta bot pushed a commit that referenced this pull request Jul 31, 2024
OKTA-753914 fix: english leak for "Close" in Autocomplete (#2291)

OKTA-742653 English leak for "Close" in Autocomplete
feat: pageTemplate and Layout component (#2219)

OKTA-721245 feat: start layout component
feat: more work on layout component
feat: documentation and syntax updates
fix: update to storybook and component
feat: add more to Storybook
fix: remove unncessary MUI ScopedCssBaseline
feat: add full-width story
feat(odyssey-react-mui): create surface component
feat(odyssey-react-mui): create stories for Grid
feat(odyssey-react-mui): remove surface styling from Grid
fix: small nit fixes
feat(odyssey-react-mui): panes => regions
fix(odyssey-react-mui): rename components and add disclaimer
fix: standardize vertical layout distance
refactor: update css
refactor: alphabetize the imports
feat: add rudimentary responsiveness to Layout
refactor: improve nested selectors
refactor: update based on code review
Merge branch 'main' into ti-OKTA-721245-layout-component
fix: update redundant type export
fix: data Table legacy improvements (#2294)

OKTA-753577 feat: add max pages and max rows per page to pagination
feat: add manual pagination next disabling
feat: reset pagination if search or filters changes
refactor: alphabetize props
feat: fixing pagination bug
refactor: improve pagination calculation
refactor: update currentRowsCount to be non-breaking
chore(odyssey-react-mui): fix Layout story margin
chore(odyssey-react-mui): bump to 1.20.0. not done in main by error
chore: back to 1.19.0
chore: bump back to 1.20.0 and generate changelog
Merge branch 'main' into bc_backport_1.20
Merge remote-tracking branch 'origin/main' into bc_backport_1.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants