Adds Storybook topic deploys to Bacon #2292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d699b18.
Also cleaned up `bacon.yml` and used `yarn-berry` script.
benschell-okta
previously approved these changes
Jul 17, 2024
| @@ -0,0 +1,65 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Is this -temp file still needed? I don't see it referenced in .bacon.yml or the other scripts.
There was a problem hiding this comment.
Yes. I might switch over to this -temp method of hitting Aperture after I finish up the other tasks, so we're not having to hit S3 directly.
bryancunningham-okta
previously approved these changes
Jul 18, 2024
KevinGhadyani-Okta
dismissed stale reviews from bryancunningham-okta and benschell-okta
via
9b692fc
bryancunningham-okta
approved these changes
Jul 18, 2024
|
I can't merge this because of unverified commits. Creating a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-740028
Summary
Storybook is now a first-class citizen in our Bacon CI.
Testing & Screenshots