Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(odyssey-design-tokens): using correct weights in SB #2363

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix(odyssey-design-tokens): using correct weights in SB #2363

merged 2 commits into from
Sep 19, 2024

Conversation

bryancunningham-okta
Copy link
Contributor

REPLACE_WITH_JIRA_TICKET_NUMBER

Summary

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

KevinGhadyani-Okta
KevinGhadyani-Okta approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@KevinGhadyani-Okta KevinGhadyani-Okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me since I did the previous fonts. Another designer should go over the font usage based on our design tokens too.

@bryancunningham-okta bryancunningham-okta marked this pull request as ready for review September 19, 2024 16:54
@bryancunningham-okta bryancunningham-okta requested a review from a team as a code owner September 19, 2024 16:54
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit 2dfa614 into main Sep 19, 2024
3 checks passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the bc-sb-font-updates branch September 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinGhadyani-Okta KevinGhadyani-Okta KevinGhadyani-Okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryancunningham-okta @KevinGhadyani-Okta