Add DateTimePicker #2391
Merged
Add DateTimePicker #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
219
to
223
| const slots = useMemo<DatePickerSlots<DateTime>>( | ||
| () => ({ | ||
| actionBar: MemoizedActionBar, | ||
| actionBar: DateFieldActionBar, | ||
| field: (muiProps) => renderDateField(muiProps), | ||
| leftArrowIcon: () => <ArrowLeftIcon />, | ||
| rightArrowIcon: () => <ArrowRightIcon />, | ||
| switchViewIcon: () => <ChevronDownIcon />, | ||
| leftArrowIcon: () => <commonIcons.ArrowLeftIcon />, | ||
| rightArrowIcon: () => <commonIcons.ArrowRightIcon />, | ||
| switchViewIcon: () => <commonIcons.ChevronDownIcon />, | ||
| }), | ||
| [renderDateField], | ||
| [commonIcons, renderDateField], | ||
| ); |
There was a problem hiding this comment.
Why are we loading the icons like this? Are we taking them in as props or something?
There was a problem hiding this comment.
They are being returned from the hook in an object called commonIcons Rather than importing them into every date picker variation manually
There was a problem hiding this comment.
bryancunningham-okta
force-pushed
the
bc-datetime-picker
branch
3 times, most recently
from
9544f65 to
e4255fb
Compare
bryancunningham-okta
force-pushed
the
bc-datetime-picker
branch
from
e4255fb to
e772700
Compare
jordankoschei-okta
previously approved these changes
Dec 2, 2024
|
|
||
| const theme: ThemeOptions = { | ||
| components: { | ||
| // MuiClock: { |
There was a problem hiding this comment.
We should remove these commented-out portions before merging
| color: theme.typography.body1.color, | ||
|
|
||
| "& + &": { | ||
| marginInlineStart: theme.spacing(2), |
There was a problem hiding this comment.
I appreciate how consistent you are with using logical properties 👏
jordankoschei-okta
previously approved these changes
Dec 3, 2024
jordankoschei-okta
previously approved these changes
Dec 4, 2024
bryancunningham-okta
dismissed
jordankoschei-okta’s stale review
The merge-base changed after approval.
bryancunningham-okta
force-pushed
the
bc-datetime-picker
branch
from
32aec4e to
72288b1
Compare
jordankoschei-okta
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DES-6573
Summary
Testing & Screenshots