feat: new popoverContent feature for MenuButton, plus UserProfileMenuButton #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benschell-okta
commented
Nov 15, 2024
There was a problem hiding this comment.
Unfortunately, moving ../Button to ../Buttons/Button meant I had to update lots of references. This PR is therefore a bit cluttered, but there should be no material changes outside of the Buttons and UserProfileMenuButton
1 task
| @@ -174,31 +215,52 @@ const MenuButton = ({ | |||
| id={`${uniqueId}-button`} | |||
| isDisabled={isDisabled} | |||
| label={buttonLabel} | |||
| children={buttonChildren} | |||
There was a problem hiding this comment.
NON-BLOCKING
I'd like to fix the types for if children or label, but not in this PR. Bryan's working on this already.
My comment is here for historical purposes.
KevinGhadyani-Okta
approved these changes
Nov 19, 2024
oktapp-aperture-okta
bot
deleted the
bs-OKTA-826088-button-enhancements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OKTA-826088
Summary
popoverContentprop for *MenuButton to allow a generic popover instead of a Mui MenuUserProfileMenuButtonwhich uses BaseMenuButton to render the existing UserProfile presentational component.Testing & Screenshots