Update Button styles + support for aria-expanded #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancunningham-okta
approved these changes
Nov 20, 2024
benlister-okta
force-pushed
the
bl_button_update1124
branch
from
25a17e2 to
2e8f79e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DES-6770
Summary
Updates
Buttonstyles to match Nick's latest updates in FigmaStates that have changed:
This PR also adds support for the
MenuButton's "open" state aka&[aria-expanded='true']and applies the:activestate styles when aMenuButtonis in this state.Testing & Screenshots