AppTile adjustments #2424
AppTile adjustments #2424
Conversation
| variant === "compact" | ||
| ? APP_TILE_COMPACT_IMAGE_HEIGHT | ||
| : APP_TILE_IMAGE_HEIGHT, | ||
| width: variant === "compact" ? "100%" : "auto", |
There was a problem hiding this comment.
If we are setting a height on these images, we probably should not set a width. It can skew the images
There was a problem hiding this comment.
What happens in the event someone uses an img that is much wider than it is tall? Will it overflow the container?
There was a problem hiding this comment.
This is how it looks in practice, with multiple aspect ratios:
There was a problem hiding this comment.
It's hard to tell with these types of placeholder images. Have you tried it with more realistic images? My hunch is we get some interesting results. Mainly that the image would be very skewed in the 'wide' case
There was a problem hiding this comment.
But, I could be wrong.
There was a problem hiding this comment.
I was able to manually verify that each image maintains the aspect ratio of its full-size equivalent
packages/odyssey-storybook/src/components/odyssey-labs/AppTile/AppTile.stories.tsx
Show resolved
Hide resolved
This PR fixes a height issue with
AppTileand adds the newcompactvariant required by End User Dashboard.