Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1.28.2 conflicts and reset to v1.28.0 #2435

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix 1.28.2 conflicts and reset to v1.28.0 #2435

merged 4 commits into from
Dec 4, 2024

Conversation

bryancunningham-okta
Copy link
Contributor

@bryancunningham-okta bryancunningham-okta commented Dec 3, 2024 •
edited
Loading

DES-6856

Summary

Testing & Screenshots

  • I have confirmed this change with my designer and the Odyssey Design Team.

benschell-okta and others added 3 commits December 3, 2024 18:17
@benschell-okta @bryancunningham-okta
Redo react 17 compatibility (#2433)
e5e61a7 
* Revert "React 17 compatibility (as patch to 1.28) (#2431)"

This reverts commit 8a51b78.

* fix: move UiShell, renderReactInWebComponent into separate export for React 17 compatibility

* fix: related storybook updates
@bryancunningham-okta
build: bump versions for 1.28.2
8112dfc
@bryancunningham-okta
docs: update CHANGELOG for 1.28.2
098067c
@bryancunningham-okta bryancunningham-okta marked this pull request as ready for review December 4, 2024 14:23
@bryancunningham-okta bryancunningham-okta requested a review from a team as a code owner December 4, 2024 14:23
@bryancunningham-okta bryancunningham-okta changed the title Bc fix 1.28.2 conflicts Fix 1.28.2 conflicts and reset to v1.28.0 Dec 4, 2024
@oktapp-aperture-okta oktapp-aperture-okta bot merged commit e8ee2be into main Dec 4, 2024
1 check passed
@oktapp-aperture-okta oktapp-aperture-okta bot deleted the bc-fix-1.28.2-conflicts branch December 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordankoschei-okta jordankoschei-okta jordankoschei-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryancunningham-okta @jordankoschei-okta @benschell-okta