Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📦 Increment version to deploy design-docs #449

Merged
merged 2 commits into from
Apr 3, 2020
Merged

📦 Increment version to deploy design-docs #449

merged 2 commits into from
Apr 3, 2020

Conversation

jmelberg-okta
Copy link
Contributor

Description

  • Increments version to0.1.1 to deploy new design-docs package.
  • Updates CODEOWNERS to require DS review on scss, html, and md files.
    • Require eng-uicore review on everything else (js, json, sh)

@jmelberg-okta jmelberg-okta requested a review from a team as a code owner April 3, 2020 19:42
@jmelberg-okta jmelberg-okta mentioned this pull request Apr 3, 2020
Closed
edburyenegren-okta
edburyenegren-okta approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@edburyenegren-okta edburyenegren-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 now we got a version match 😁

@jmelberg-okta jmelberg-okta merged commit 1df5473 into master Apr 3, 2020
@jmelberg-okta jmelberg-okta deleted the jm-0.1.1 branch April 3, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edburyenegren-okta edburyenegren-okta edburyenegren-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmelberg-okta @edburyenegren-okta