removes legacy PKCE and OAuth storage #1181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aarongranick-okta
commented
Apr 14, 2022
aarongranick-okta
commented
- removes legacy storage: PKCE meta, OAuth redirect cookie, state/nonce cookies
- parseFromUrl: adds specific error for missing transaction when using PKCE to maintain compatibility
- this is a breaking change as without legacy storage AuthJS will no longer be compatible with widget version < 5.4.0
shuowu-okta
approved these changes
Apr 14, 2022
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Apr 14, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Apr 29, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Apr 29, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Jun 13, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Jul 5, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Aug 12, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Aug 16, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Aug 29, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
shuowu-okta
pushed a commit
that referenced
this pull request
Aug 30, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Sep 6, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
shuowu-okta
pushed a commit
that referenced
this pull request
Sep 16, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
aarongranick-okta
added a commit
that referenced
this pull request
Sep 21, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
eng-prod-CI-bot-2-okta
pushed a commit
that referenced
this pull request
Sep 22, 2022
OKTA-362589 <<<Jenkins Check-In of Tested SHA: 64c5b97 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 17 PR Link: "#1181"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.