breaking change: do not throw IDX responses as errors #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongranick-okta
changed the title
jaredperreault-okta
approved these changes
May 6, 2022
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
May 9, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Jun 13, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Jun 13, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Jul 5, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Aug 12, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Aug 16, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Aug 29, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
shuowu-okta
pushed a commit
that referenced
this pull request
Aug 30, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Sep 6, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
shuowu-okta
pushed a commit
that referenced
this pull request
Sep 16, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
aarongranick-okta
added a commit
that referenced
this pull request
Sep 21, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
eng-prod-CI-bot-2-okta
pushed a commit
that referenced
this pull request
Sep 22, 2022
OKTA-481844 <<<Jenkins Check-In of Tested SHA: c2ae026 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 15 PR Link: #1205
Except this appears to just be a boolean, we don't have access to the error properties or an HTTP status code. |
|
The error should be in the IDX payload as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthJS has been preserving behavior from idx-js where IDX responses with a non-200 HTTP status are thrown as exceptions
We have added a property to response
requestDidSucceedso this information is available without it being thrown.With this change all IDX responses will be resolved