Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: launch-authenticator relatesTo work-around #1466

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

lesterchoi-okta
Copy link
Contributor

No description provided.

@lesterchoi-okta lesterchoi-okta deleted the jp-OKTA-659175 branch October 18, 2023 20:13
@lesterchoi-okta lesterchoi-okta restored the jp-OKTA-659175 branch October 18, 2023 20:13
remediation => {
// TODO: remove once IDX is fixed - OKTA-659181
if (remediation.name === 'launch-authenticator' &&
remediation?.relatesTo[0] === 'authenticatorChallenge' &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
remediation?.relatesTo[0] === 'authenticatorChallenge' &&
remediation?.relatesTo?.[0] === 'authenticatorChallenge' &&

remediation => {
// TODO: remove once IDX is fixed - OKTA-659181
if (remediation.name === 'launch-authenticator' &&
remediation?.relatesTo?.[0] === 'authenticatorChallenge' &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any danger in assuming it's the first and only item in relatesTo?

Suggested change
remediation?.relatesTo?.[0] === 'authenticatorChallenge' &&
remediation.relatesTo?.indexOf('authenticatorChallenge') >= 0 &&

@jaredperreault-okta jaredperreault-okta marked this pull request as ready for review October 18, 2023 23:06
@jaredperreault-okta jaredperreault-okta changed the base branch from master to 7.4 October 18, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants