use native fetch (if available) #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongranick-okta
force-pushed
the
ag-OKTA-359210-native-fetch
branch
from
58074cf
to
aaee9cf
Compare
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 92.98% 92.98%
=======================================
Files 38 38
Lines 2167 2168 +1
Branches 454 455 +1
=======================================
+ Hits 2015 2016 +1
Misses 152 152
Continue to review full report at Codecov.
|
magizh-okta
reviewed
Jan 8, 2021
| @@ -52,7 +52,7 @@ function fetchRequest(method: string, url: string, args: FetchOptions) { | |||
| if (contentType === 'application/json' && body && typeof body !== 'string') { | |||
| body = JSON.stringify(body); | |||
| } | |||
|
|
|||
| var fetch = global.fetch || crossFetch; | |||
There was a problem hiding this comment.
Can we add a test to make sure global fetch is called if fetch is defined else crossFetch is called.
shuowu
approved these changes
Jan 8, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bypasses the
cross-fetchmodule when native fetch is available