Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Add additional Runscope SCIM tests #3871

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Draft: Add additional Runscope SCIM tests #3871

wants to merge 3 commits into from

Conversation

bdemers
Copy link
Contributor

@bdemers bdemers commented Jan 10, 2023 •
edited

Adds tests for:

  • PUT /Users/ - add attributes
  • PATCH /Users/ - disable user
  • POST /Groups - create group
  • GET /Groups/ - get group
  • PUT /Groups/ - update group
  • PATCH /Groups/ - update group users
  • DELETE /Groups/ - delete group

TODO: These new tests are not needed for every type of implementation. For example, OIN apps have a different set of tests they MUST pass, for example, OIN apps will use a PATCH request when disabling a user, and a "custom" app will use a PUT.

NOTE: The ordering of the JSON properties has changed when using the Runscopes "export" feature; we may want to start running these files through a script that will use a deterministic ordering.

@bdemers bdemers changed the title Add additional Runscope SCIM tests Draft: Add additional Runscope SCIM tests Jan 10, 2023
@bdemers
Add additional Runscope SCIM tests
d71e26b 
Adds tests for:
* PUT /Users/<id> - add attributes
* PATCH /Users/<id> - disable user
* POST /Groups - create group
* GET /Groups/<id> - get group
* PUT /Groups/<id> - update group
* PATCH /Groups/<id> - update group users
* DELETE /Groups/<id> - delete group
@brianduffield-okta brianduffield-okta added the On Hold For features that were going to be released, but are now on hold label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susanharper-okta susanharper-okta Awaiting requested review from susanharper-okta susanharper-okta will be requested when the pull request is marked ready for review susanharper-okta is a code owner

@kimmaida-okta kimmaida-okta Awaiting requested review from kimmaida-okta kimmaida-okta will be requested when the pull request is marked ready for review kimmaida-okta is a code owner

@janethu-okta janethu-okta Awaiting requested review from janethu-okta janethu-okta will be requested when the pull request is marked ready for review janethu-okta is a code owner

@grahamsmith-okta grahamsmith-okta Awaiting requested review from grahamsmith-okta grahamsmith-okta will be requested when the pull request is marked ready for review grahamsmith-okta is a code owner

@barbaravo-okta barbaravo-okta Awaiting requested review from barbaravo-okta barbaravo-okta will be requested when the pull request is marked ready for review barbaravo-okta is a code owner

@emikhasyak-okta emikhasyak-okta Awaiting requested review from emikhasyak-okta emikhasyak-okta will be requested when the pull request is marked ready for review emikhasyak-okta is a code owner

@paulwallace-okta paulwallace-okta Awaiting requested review from paulwallace-okta paulwallace-okta will be requested when the pull request is marked ready for review paulwallace-okta is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
On Hold For features that were going to be released, but are now on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bdemers @brianduffield-okta