-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mds/okta 524282/okta 528021 update mobile sdk overview #4332
base: master
Are you sure you want to change the base?
Mds/okta 524282/okta 528021 update mobile sdk overview #4332
Conversation
- Updated main index and diagrams for modified object names. - Initial update of iOS - Added and modified new files for Android
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Left a suggestion for updating a diagram
...s/@okta/vuepress-site/.vuepress/public/img/mobile-sdk/mobile-idx-objects-and-flow-kotlin.png
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/android/initializeflow.md
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird case of deja vu here in that the Kotlin SDK class diagram doesn't match the text. I know I did a PR review for you where this was also true. Also have suggested a few spots where code lines are too long for a midsized browser window. I don't know how easy it is to split Swift code over two lines though.
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/index.md
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/index.md
Outdated
Show resolved
Hide resolved
...s/@okta/vuepress-site/.vuepress/public/img/mobile-sdk/mobile-idx-objects-and-flow-kotlin.png
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/.vuepress/public/img/mobile-sdk/mobile-idx-basic-objects.png
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/android/objectsandflow.md
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/ios/initializeflow.md
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/ios/processresponse.md
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/ios/processresponse.md
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/ios/gettingatoken.md
Outdated
Show resolved
Hide resolved
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/ios/gettingatoken.md
Show resolved
Hide resolved
- Fine tuned text based on review comments - Revised the Android flow image to use proper object names
- **Authenticator:** Represents an authenticator that's used to verify the identity of a user, such as Okta Verify. | ||
- **Method:** Represents a channel for an authenticator, such as using SMS or voice for an authenticator that uses a phone. An authenticator may have zero or more. | ||
- **Method:** Represents a channel for an authenticator, such as using SMS or voice for an authenticator that uses a phone. An authenticator may have zero or more methods. | ||
- **Capability:** A user action associated with a remediation, authenticator, or method, such as requesting a new OTP or a password reset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A capability can also indicate additional data associated with an authenticator that isn't always present. For example, a Password authenticator may sometimes return "PasswordSettings" to describe the password complexity requirements (usually only available when setting a new password). Another useful one is the "Profile" capability, which returns additional display information for the authenticator that can be used to render a UI (such as the redacted email address or phone number used within an authenticator).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How's this?
- Capability: A user action or additional information that is associated with a remediation, authenticator, or method, such as requesting a new OTP or a redacted email.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Instead of "redacted email", I'd clarify further, such as: "or the email address or phone number associated with the authenticator (redacted for security)."
For the Swift samples, is it using the new code in the SwiftUI-Improvements branch? |
packages/@okta/vuepress-site/docs/guides/mobile-idx-sdk-overview/main/ios/signingout.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/netlify preview |
Latest preview build (Sep 5 5:15PM Eastern)
Android/Kotlin
Swift/iOS
Description:
What's changed?
InteractionCodeFlow
InteractionCodeFlowDelegate
and to publish the relevant state variables.Is this PR related to a Monolith release?
No
Resolves: