Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKTA-736640 - Add new event type #4921

Merged

Conversation

brianduffield-okta
Copy link
Contributor

@brianduffield-okta brianduffield-okta commented Jun 24, 2024

Description:

  • What's changed? Adding new event type for ITP July monthly release.
  • Is this PR related to a Monolith release? 2024.08.0

Resolves:

@eng-info-dev-github-bot

Netlify Preview URL for the changes: https://preview-4921--reverent-murdock-829d24.netlify.app

## user risk detect
`user.risk.detect`

**Description:** This event type indicates a user risk was detected. It can be used to monitor risk level detections for users. This event triggers when Okta detects that a user is associated with risk activity or context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions of other event types seem to vary, but some use the present tense. This one should probably align with the style guide.

Suggested change
**Description:** This event type indicates a user risk was detected. It can be used to monitor risk level detections for users. This event triggers when Okta detects that a user is associated with risk activity or context.
**Description:** Indicates a user risk is detected. Use it to monitor risk level detections for users. This event triggers when Okta detects that a user is associated with risk activity or context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yes, this is a little clunky. Let me re-draft to match the existing event types.

Copy link
Contributor

@brentschaus-okta brentschaus-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested.

@susanharper-okta susanharper-okta added the docs release Tagged to be released during scheduled docs release label Aug 1, 2024
@thomascavanagh-okta thomascavanagh-okta changed the base branch from master to release-2024.08.0 August 8, 2024 16:42
@thomascavanagh-okta thomascavanagh-okta merged commit 023a6ee into release-2024.08.0 Aug 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Brent docs release Tagged to be released during scheduled docs release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants