Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md - Remove inadvertently included style tag #4961

Closed
wants to merge 1 commit into from

Conversation

mattbartley
Copy link

Removed the rendered style string. It may have been carried over from a different type of document, but it renders in plain text in markdown.

Description:

  • What's changed?
  • Removed the rendered style string "{style="list-style-type:lower-alpha"}".
  • It may have been carried over from a different type of document, but it renders in plain text in markdown.
  • Is this PR related to a Monolith release?
  • Unsure/Unlikely

Removed the rendered style string. It may have been carried over from a different type of document, but it renders in plain text in markdown.
@acrolinxdevdocs-okta
Copy link
Contributor

Acrolinx score

A minimum Acrolinx Score of 80 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, for example: Correctness. Your content will be clearer and more consistent.

Article Total score
Required:80
Word and phrases
(Brand, terms)
Preferred: 80
Correctness
(Spelling, grammar)
Preferred: 80
Clarity
(Readability)
Preferred: 80
Inclusive language
(+ accesibility)
Preferred: 80
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/index.md 87 83 100 71 99

@brianduffield-okta
Copy link
Contributor

Thanks for your PR, @mattbartley . It looks like the style tag was inadvertently placed, and should produce an alpha-numeric list in the second order ol. I'm going to create another PR to implement it correctly. Many thanks for calling it out!

@mattbartley
Copy link
Author

I'm going to create another PR to implement it correctly. Many thanks for calling it out!

Great! It looks like there are several other instances for "{style="list-style-type:lower-alpha"}" in the docs. I was able to find 14 others by searching the repo for only '{style=' as the query to catch any other style objects being used, but the only results are the list-style-type, so it doesn't seem to be a broader issue.

@brianduffield-okta
Copy link
Contributor

Thanks, yes, we noticed that as well. It looks to be a tooling update that might've broken things. Our team is looking into it. Thanks again.

@brianduffield-okta
Copy link
Contributor

Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants