Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use browser querying logic from okta-mobile-kotlin #347

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

rajdeepnanua-okta
Copy link
Contributor

Description:

Copied over the browser querying logic from okta-mobile-kotlin, which avoids having to use matchAll flag when the default system browser doesn't support chrome custom tabs.

Testing details:

  • Verified basic functionality of change
  • Added tests

Other considerations:

  • Has security implications
  • Has UX changes
RESOLVES:

OKTA-XXXXX

Primary Reviewer(s):

Additional Reviewers:
Security Reviewer(s) (@ okta/rex-team if necessary):
UX Reviewer(s) (if necessary):

@rajdeepnanua-okta rajdeepnanua-okta merged commit ecbb946 into master Jan 4, 2023
@rajdeepnanua-okta rajdeepnanua-okta deleted the rn_browserQuery branch January 4, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants