Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

fix[okta-react-native]: Lock to 0.55.4, add package-lock #239

Merged
merged 1 commit into from
Jul 10, 2018

Conversation

robertjd
Copy link
Contributor

@robertjd robertjd commented Jul 9, 2018

Tests have started failing (see Build #699).

I tried upgrading the jest and/or the babel plugins, per these threads:

facebook/react-native#19859
jestjs/jest#6505

But I didn't have any luck. Locking to the 0.55 series of react-native does seem to fix this problem for now.

Tests have started failing (see [Build #699](https://travis-ci.org/okta/okta-oidc-js/builds/401943311)).

I tried upgrading the jest and/or the babel plugins, per these threads:

facebook/react-native#19859
jestjs/jest#6505

But I didn't have any luck.  Locking to the 0.55 series of react-ntaive does seeem to fix this problem
Copy link
Contributor

@jmelberg-okta jmelberg-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you you create an issue for us to investigate upgrading the jest and/or the babel plugins?

@robertdamphousse-okta robertdamphousse-okta merged commit 5b197c5 into master Jul 10, 2018
@robertdamphousse-okta robertdamphousse-okta deleted the rd-fix-rn-tests branch July 10, 2018 00:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants