Merge pull request #117 from okta/92-update-group

Group Update and a small big fix 💥
okta · Jul 7, 2017 · 22e40ae · 22e40ae
2 parents 970bea3 + f4fd7bd
commit 22e40ae
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/src/Okta.Sdk.IntegrationTests/GroupScenarios.cs b/src/Okta.Sdk.IntegrationTests/GroupScenarios.cs
@@ -91,10 +91,32 @@ await Assert.ThrowsAsync<OktaApiException>(
                 () => client.Groups.GetGroupAsync(createdGroup.Id));
         }
 
-        [Fact(Skip = "TODO")]
+        [Fact]
         public async Task UpdateGroup()
         {
-            throw new NotImplementedException();
+            var client = GetClient("group-update");
+
+            var createdGroup = await client.Groups.CreateGroupAsync(new CreateGroupOptions
+            {
+                Name = "Update Test Group",
+            });
+
+            await Task.Delay(1000);
+            createdGroup.Profile.Description = "This group has been updated";
+
+            try
+            {
+                var updatedGroup = await createdGroup.UpdateAsync();
+                updatedGroup.LastUpdated.Value.Should().BeAfter(updatedGroup.Created.Value);
+            }
+            finally
+            {
+                await createdGroup.DeleteAsync();
+            }
+
+            // Getting by ID should result in 404 error
+            await Assert.ThrowsAsync<OktaApiException>(
+                () => client.Groups.GetGroupAsync(createdGroup.Id));
         }
 
         [Fact(Skip = "TODO")]

diff --git a/src/Okta.Sdk/OktaClient.cs b/src/Okta.Sdk/OktaClient.cs
@@ -165,7 +165,7 @@ protected CollectionClient<T> GetCollectionClient<T>(HttpRequest initialRequest)
         public async Task<TResponse> PutAsync<TResponse>(HttpRequest request, CancellationToken cancellationToken = default(CancellationToken))
             where TResponse : Resource, new()
         {
-            var response = await _dataStore.PostAsync<TResponse>(request, _requestContext, cancellationToken).ConfigureAwait(false);
+            var response = await _dataStore.PutAsync<TResponse>(request, _requestContext, cancellationToken).ConfigureAwait(false);
             return response?.Payload;
         }